Don't write RPM standard output as error #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Changes look good to me. Could you fix scalafmt errors please? (check travis build) |
|
Sure. I did this in the github UI 😊 |
Currently stdout for building an RPM gets output at error level. ``` [error] + umask 022 [error] + cd /home/david/test/target/rpm/BUILD [error] + /bin/rm -rf /home/david/test/target/rpm/buildroot [error] + exit 0 ```
|
@Falmarri thanks for fixing this! 😍 I lived under the impression that |
|
does this work? Just tried this on linux ( |
|
Hmm. it's possible that I incorrectly identified the problem and that rpm outputting to stderr is actually the root cause. I'll inspect the rpm command more |
|
OK you guys are right. It does write the output to stderr regardless. How about this? #1212 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently stdout for building an RPM gets output at error level.